Project

General

Profile

Actions

Bug #14176

closed

pcieadm aer cap compares wrong field

Added by Robert Mustacchi about 1 month ago. Updated 29 days ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While working through #14174 I noticed that we were comparing walkp->pcw_dtype to the type of PCIe device in pcieadm_cap_info_aer. Unfortunately that contains the device header type, e.g. type 0 or type 1. Instead we need to be using walkp->pcw_pcietype which contains the type of PCIe device. I haven't been able to find an example of this in the wild.

Actions #1

Updated by Electric Monk about 1 month ago

  • Gerrit CR set to 1765
Actions #2

Updated by Robert Mustacchi about 1 month ago

This was generally tested alongside #14174 and #14175. There wasn't a great way to test this currently other than the test suite as I don't have access to systems with support for non-express PCI.

Actions #3

Updated by Electric Monk 29 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit bc729d490568bb6599aac50d559e64c366738e85

commit  bc729d490568bb6599aac50d559e64c366738e85
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2021-10-28T21:30:51.000Z

    14174 pcieadm needs to handle v1 pcie cap better
    14175 pcieadm show-devs can do better on missing pcidb entries
    14176 pcieadm aer cap compares wrong field
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF