Project

General

Profile

Actions

Feature #14187

open

custr_remove can act on its no-more-gcc4 comment

Added by Dan McDonald about 2 years ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

And I quote:

int
custr_remove(custr_t *cus, size_t idx, size_t len)
{
        size_t endidx = idx + len;

        /*
         * Once gcc4 is dropped as a shadow compiler, we can migrate to
         * using builtins for the overflow check.
         */
        if (endidx < idx || endidx < len) {
                errno = EINVAL;
                return (-1);
        }

Now that gcc4 is officially gone, this comment can be acted upon.

No data to display

Actions

Also available in: Atom PDF