Project

General

Profile

Actions

Bug #14219

closed

cw: clang does not like B_FALSE/B_TRUE with c99

Added by Toomas Soome 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

https://clang.llvm.org/doxygen/OSTargets_8h_source.html (line 636).

c99 mode in clang does set _XOPEN_SOURCE=600 which will trigger (via sys/feature_tests.h):

typedef enum { _B_FALSE, _B_TRUE } boolean_t;
..

while it may not be something we want to happen, we can just switch cw to use stdbool.h instead.

Testing done: nightly run.

Actions #1

Updated by Electric Monk 3 months ago

  • Gerrit CR set to 1783
Actions #2

Updated by Toomas Soome 2 months ago

  • Subject changed from clang does not like B_FALSE/B_TRUE with c99 to cw: clang does not like B_FALSE/B_TRUE with c99
Actions #3

Updated by Toomas Soome 2 months ago

  • Description updated (diff)
Actions #4

Updated by Electric Monk 2 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 22a8b493c14c29001395d6df0b6fe6bb52d36947

commit  22a8b493c14c29001395d6df0b6fe6bb52d36947
Author: Toomas Soome <tsoome@me.com>
Date:   2021-11-17T19:46:24.000Z

    14219 cw: clang does not like B_FALSE/B_TRUE with c99
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF