Project

General

Profile

Actions

Bug #14232

closed

several smbios_info_* routines don't check for bad ids

Added by Robert Mustacchi 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

There is a common pattern in common/smbios/smb_info.c where folks call smb_lookup_id in the opening stanza and are supposed to check later for success. However, a large number of such entry points didn't do this (several of which are my fault). This goes back and adds them and adds a test case to catch this as well.

Actions #1

Updated by Robert Mustacchi 7 months ago

  • Tracker changed from Feature to Bug
Actions #2

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 1796
Actions #3

Updated by Electric Monk 6 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit d53cdfab6d4896af92b7a3df87a26060caf179ae

commit  d53cdfab6d4896af92b7a3df87a26060caf179ae
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2021-11-19T01:47:24.000Z

    14231 want support for SMBIOS 3.5
    14232 several smbios_info_* routines don't check for bad ids
    14233 smbios_info_chassis calculates sku number incorrectly
    14234 smbios chassis elements need work
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Rich Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF