Project

General

Profile

Bug #1426

Feature #1361: Add support for socket options TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL

1361 missed two codepaths

Added by Dan McDonald almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2011-08-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

The changes for bug 1361 missed two codepaths (and this code reviewer takes full responsibility for missing them during review).

1.) The tcp_reinit_values() function needs to mention every field in tcp_t, according to the header file. It actually doesn't, but our new fields should be mentioned in there.

2.) tcp_init_values() has a (parent != NULL) case (i.e. sockets created by accept(3xn)) which doesn't copy over the new values.


Files

acceptor.c (2.02 KB) acceptor.c Test program Dan McDonald, 2011-08-30 03:12 PM

History

#1

Updated by Dan McDonald almost 8 years ago

Attached is a test program (acceptor.c) that'll open a server-side socket. Once you telnet to that port (default == 2112), it'll accept one connection, and compare parent vs. child values of the tcp_t fields in question.

#2

Updated by Garrett D'Amore almost 8 years ago

  • % Done changed from 80 to 100

Resolved in:

changeset: 13443:76ab5b799560
tag: tip
user: Dan McDonald <>
date: Tue Aug 30 09:23:32 2011 -0700
description:
1426 1361 missed two codepaths
Reviewed by: Garrett D'Amore <>
Reviewed by: Richard Lowe<>
Reviewed by: Albert Lee<>
Approved by: Garrett D'Amore <>

#3

Updated by Garrett D'Amore almost 8 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF