Project

General

Profile

Actions

Bug #1426

closed

Feature #1361: Add support for socket options TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL

1361 missed two codepaths

Added by Dan McDonald almost 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
kernel
Start date:
2011-08-29
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The changes for bug 1361 missed two codepaths (and this code reviewer takes full responsibility for missing them during review).

1.) The tcp_reinit_values() function needs to mention every field in tcp_t, according to the header file. It actually doesn't, but our new fields should be mentioned in there.

2.) tcp_init_values() has a (parent != NULL) case (i.e. sockets created by accept(3xn)) which doesn't copy over the new values.


Files

acceptor.c (2.02 KB) acceptor.c Test program Dan McDonald, 2011-08-30 03:12 PM
Actions

Also available in: Atom PDF