Project

General

Profile

Actions
Copy link

Bug #14275

closed

crt object .comment sections should be string mergeable

Added by Rich Lowe 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1827

Description

The CRT objects contain non-mergeable string .comment sections.

This is because the sections are added by mcs(1) rather than being created by the compiler or assembler and then edited. We should add a dummy .ident that mcs can replace.

Actions
Copy link
 #1

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 1827
Actions
Copy link
 #2

Updated by Rich Lowe 6 months ago

testing:
Build and wsdiff (minor symtab, shstrtab, etc. changes because .comment is seen in objects earlier in the link-edit)
Build outside of the illumos build system and checked that idents from the CRT now merge together.

Actions
Copy link
 #3

Updated by Electric Monk 6 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 5e0a5eb736a773e9ab13bae98d1998788ce0f4f9

commit  5e0a5eb736a773e9ab13bae98d1998788ce0f4f9
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2021-12-02T19:51:13.000Z

    14275 crt object .comment sections should be string mergeable
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF