Project

General

Profile

Actions

Bug #14288

closed

mdbtest finds no tests when invoked by test runner

Added by Robert Mustacchi 9 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While looking at wrapping up #14269 I found that there while the test passed, none of the tests were run by mdbtest when executed by the test runner:

$ cat /var/tmp/test_results/20211204T175813/mdbtest/stdout
Starting tests...
mtest target: /usr/bin/mdb
output directory: /var/tmp/mdbtest.2640

-------------
Results
-------------

Tests passed: 0
Tests failed: 0
Tests ran:    0

Congrats, mdb isn't completely broken, the tests pass.

This isn't very useful. When I originally wrote this, it expected you to be executing it from the root directory ala dtest a bit at the time. When moved into usr/src/test, this was missed. While here I'm going to add a check to make sure that we have at least one test executed or otherwise fail.

Actions #1

Updated by Electric Monk 9 months ago

  • Gerrit CR set to 1846
Actions #2

Updated by Robert Mustacchi 9 months ago

With the updated wrapper script, we see this now works:

rm@nienor:~$ cat /var/tmp/test_results/20211205T195528/mdbtest/stdout 
Starting tests...
mdbtest target: /usr/bin/mdb
output directory: /var/tmp/mdbtest.5020
Executing test ./options/tst.autowrap.mdb ... passed
Executing test ./typedef/err.badid-leadnum.ksh ... passed
Executing test ./typedef/tst.models.ksh ... passed
Executing test ./typedef/err.nokeyword.ksh ... passed
Executing test ./typedef/err.badstruct-noquotes.ksh ... passed
Executing test ./typedef/tst.structvla.mdb ... passed
Executing test ./typedef/err.badstruct-nomemsemi.ksh ... passed
Executing test ./typedef/tst.union.mdb ... passed
Executing test ./typedef/err.badstruct-noarrayclose.ksh ... passed
Executing test ./typedef/err.nomodel.ksh ... passed
Executing test ./typedef/err.noargs.ksh ... passed
Executing test ./typedef/tst.anonunion.mdb ... passed
Executing test ./typedef/err.badstruct-noclosebrace.ksh ... passed
Executing test ./typedef/err.badstruct-neglenarr.ksh ... passed
Executing test ./typedef/err.badstruct-noopenbrace.ksh ... passed
Executing test ./typedef/err.badstruct-extrabraces.ksh ... passed
Executing test ./typedef/err.badmodel.ksh ... passed
Executing test ./typedef/err.typeexists.ksh ... passed
Executing test ./typedef/err.badid-leadschar.ksh ... passed
Executing test ./typedef/err.badstruct-repmemname.ksh ... passed
Executing test ./typedef/tst.anonstruct.mdb ... passed
Executing test ./typedef/err.badstruct-noarrayopen.ksh ... passed
Executing test ./typedef/err.badunion-hasvla.ksh ... passed
Executing test ./typedef/err.noname.ksh ... passed
Executing test ./typedef/err.badstruct-nobraces.ksh ... passed
Executing test ./typedef/err.badstruct-zerolenarr.ksh ... passed
Executing test ./typedef/tst.libctype.ksh ... passed
Executing test ./typedef/tst.emptylist.mdb ... passed
Executing test ./typedef/err.badstruct-nomembers.ksh ... passed
Executing test ./typedef/err.badstruct-noarraylen.ksh ... passed
Executing test ./typedef/tst.structselfref.mdb ... passed
Executing test ./typedef/tst.cleanupstruct.ksh ... passed
Executing test ./typedef/err.badstruct-nomemname.ksh ... passed
Executing test ./typedef/tst.deftypes64.mdb ... passed
Executing test ./typedef/tst.dellist.mdb ... passed
Executing test ./typedef/tst.struct.mdb ... passed
Executing test ./typedef/err.badstruct-vlaonly.ksh ... passed
Executing test ./typedef/tst.deftypes32.mdb ... passed
Executing test ./typedef/err.extraargs.ksh ... passed
Executing test ./exit-e/err.cmdbadopt.ksh ... passed
Executing test ./exit-e/tst.simple.ksh ... passed
Executing test ./exit-e/tst.output.ksh ... passed
Executing test ./exit-e/err.nowrite.ksh ... passed
Executing test ./exit-e/err.enocmd.ksh ... passed
Executing test ./exit-e/err.unmapped.ksh ... passed
Executing test ./numbers/tst.badnums.ksh ... passed
Executing test ./numbers/tst.hex.mdb ... passed
Executing test ./numbers/tst.prefsym.ksh ... passed
Executing test ./numbers/tst.base10.mdb ... passed
Executing test ./numbers/tst.octal.mdb ... passed
Executing test ./numbers/tst.binary.mdb ... passed
Executing test ./format/tst.format-cap-E.mdb ... passed
Executing test ./format/tst.format-cap-P.mdb ... passed
Executing test ./format/tst.format-j.mdb ... passed
Executing test ./format/tst.format-cap-J.mdb ... passed
Executing test ./format/tst.format-p.mdb ... passed
Executing test ./format/tst.format-e.mdb ... passed
Executing test ./format/tst.format-cap-R.mdb ... passed
Executing test ./format/tst.format-cap-G.mdb ... passed
Executing test ./format/tst.format-g.mdb ... passed

-------------
Results
-------------

Tests passed: 60
Tests failed: 0
Tests ran:    60

Congrats, mdb isn't completely broken, the tests pass.
Actions #3

Updated by Electric Monk 7 months ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit fff59a0859385717fd41a0edf704de81c340ad00

commit  fff59a0859385717fd41a0edf704de81c340ad00
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2022-01-15T00:41:16.000Z

    14288 mdbtest finds no tests when invoked by test runner
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Approved by: Rich Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF