Project

General

Profile

Actions

Feature #14316

closed

want means to leverage ctfconvert in one go in the build

Added by Robert Mustacchi 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While ctfconvert has added the ability to do a conversion of al linked object, there is no way to currently take advantage of that in the build. While it'd be nice for this to always be the case and do it all the time instead of performing a convert and merge of objects files, it'd help to have intermediate step where we can do this for binaries without boiling the ocean all at once.

This lets someone set CTF_MODE = link after including Makefile.ctf to set it to the link mode and convert it one go.

Actions #1

Updated by Electric Monk 8 months ago

  • Gerrit CR set to 1913
Actions #2

Updated by Robert Mustacchi 7 months ago

I tested this primarily by doing a wsdiff and seeing no changes in CTF (there were changes in mdb because that had also changed in this changeset).

Actions #3

Updated by Electric Monk 7 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 7a58f53801acca2cd594b9ecb75bf926e4fb3eda

commit  7a58f53801acca2cd594b9ecb75bf926e4fb3eda
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2022-01-15T00:41:16.000Z

    14317 mdb misprints certain bitfields
    6461 mdb incorrectly prints byte-sized things at a bit-offset
    14316 want means to leverage ctfconvert in one go in the build
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Rich Lowe <richlowe@richlowe.net>

Actions

Also available in: Atom PDF