Project

General

Profile

Actions
Copy link

Bug #14326

closed

dt_unring_buf: set dtbd_oldest to the start of the first record

Added by Toomas Soome 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
DTrace
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
1883

Description

Work by Andriy Gapon:

It was set to the start of the buffer and that can be different from the
start of the first record because of a misalignment.

This change follows the example of dt_realloc_buf().

https://reviews.freebsd.org/D33649

Testing done: in use in FreeBSD, my own testing on illumos has not shown unexpected results.

Actions
Copy link
 #1

Updated by Electric Monk 8 months ago

  • Gerrit CR set to 1883
Actions
Copy link
 #2

Updated by Toomas Soome 8 months ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Toomas Soome 7 months ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 050c24f35c93857f1022f99834086ade54e70547

commit  050c24f35c93857f1022f99834086ade54e70547
Author: Andriy Gapon <avg@FreeBSD.org>
Date:   2022-01-25T19:09:51.000Z

    14326 dt_unring_buf: set dtbd_oldest to the start of the first record
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Rich Lowe <richlowe@richlowe.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF