Project

General

Profile

Actions

Bug #14332

closed

pcfs: this 'if' clause does not guard...

Added by Toomas Soome 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error with gcc 11:

    ../../common/fs/pcfs/pc_vnops.c: In function 'pcfs_putapage':
    ../../common/fs/pcfs/pc_vnops.c:1850:9: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
     1850 |         if (lenp)
          |         ^~
    In file included from ../../common/fs/pcfs/pc_vnops.c:49:
    ../../common/sys/fs/pc_fs.h:603:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
      603 |         if (pcfsdebuglevel >= level) \
          |         ^~
    ../../common/fs/pcfs/pc_vnops.c:1852:17: note: in expansion of macro 'PC_DPRINTF4'
     1852 |                 PC_DPRINTF4(4, "pcfs_putapage: vp=%p pp=%p off=%lld len=%lu\n",
          |                 ^~~~~~~~~~~
    cc1: all warnings being treated as errors

Testing done: build

Actions #1

Updated by Electric Monk 8 months ago

  • Gerrit CR set to 1888
Actions #2

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 33e89158d2c7ad02650282d7f59da2165063f410

commit  33e89158d2c7ad02650282d7f59da2165063f410
Author: Toomas Soome <tsoome@me.com>
Date:   2022-01-05T16:44:56.000Z

    14332 pcfs: this 'if' clause does not guard...
    Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF