Project

General

Profile

Actions

Bug #14338

closed

units: this 'if' clause does not guard...

Added by Toomas Soome 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors with gcc 11:

    units.c:182:17: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
      182 |                 if(u > 1)
          |                 ^~
    units.c:184:25: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
      184 |                         return(2);
          |                         ^~~~~~
    cc1: all warnings being treated as errors

Testing done: wsdiff of two built trees:

tsoome@beastie:/code/14338$ wsdiff ../14331/usr/src/cmd/units usr/src/cmd/units
/code/14331/usr/src/cmd/units/units.c
/code/14331/usr/src/cmd/units/.make.state
tsoome@beastie:/code/14338$ 

Actions #1

Updated by Electric Monk 8 months ago

  • Gerrit CR set to 1894
Actions #2

Updated by Toomas Soome 7 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 9ccfd38e64be4d6a2c01daa15fe7f5627122bdc2

commit  9ccfd38e64be4d6a2c01daa15fe7f5627122bdc2
Author: Toomas Soome <tsoome@me.com>
Date:   2022-01-04T20:32:06.000Z

    14338 units: this 'if' clause does not guard...
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF