Project

General

Profile

Actions

Bug #14344

closed

libnisdb: ISO C++17 does not allow 'register' storage class specifier

Added by Toomas Soome 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with gcc 11:

    db_index.cc: In member function 'db_index_entry* db_index::lookup(item*, long int*, db_table*, bool_t)':
    db_index.cc:190:32: error: ISO C++17 does not allow 'register' storage class specifier [-Werror=register]
      190 |         register unsigned long hval;
          |                                ^~~~
    db_index.cc: In member function 'db_status db_index::remove(item*, entryp)':
    db_index.cc:228:32: error: ISO C++17 does not allow 'register' storage class specifier [-Werror=register]
      228 |         register unsigned long hval;
          |                                ^~~~
    db_index.cc:230:34: error: ISO C++17 does not allow 'register' storage class specifier [-Werror=register]
      230 |         register db_index_entry *fst;
          |                                  ^~~
    db_index.cc: In member function 'db_status db_index::add(item*, entryp)':
    db_index.cc:268:32: error: ISO C++17 does not allow 'register' storage class specifier [-Werror=register]
      268 |         register unsigned long hval;
          |                                ^~~~
    cc1plus: all warnings being treated as errors

Just remove 'register'.

Testing done: build/install/boot, wsdiff is only showing 'ELF .debug_info difference detected.'

Actions #1

Updated by Electric Monk 8 months ago

  • Gerrit CR set to 1899
Actions #2

Updated by Toomas Soome 7 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 439b932b1a6fbc5105bd6987cb696a707183a149

commit  439b932b1a6fbc5105bd6987cb696a707183a149
Author: Toomas Soome <tsoome@me.com>
Date:   2022-01-06T16:23:59.000Z

    14344 libnisdb: ISO C++17 does not allow 'register' storage class specifier
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF