Project

General

Profile

Actions

Bug #14349

closed

libcrypt: mismatched bound

Added by Toomas Soome 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with gcc 11:

    ../common/cryptio.c:68:16: error: argument 1 of type 'int[2]' with mismatched bound [-Werror=array-parameter=]
       68 | run_setkey(int p[2], const char *keyparam)
          |            ~~~~^~~~
    In file included from ../common/cryptio.c:45:
    /code/illumos-gate/proto/root_i386/usr/include/crypt.h:57:23: note: previously declared as 'int *'
       57 | extern int run_setkey(int *, const char *);
          |                       ^~~~~
    ../common/cryptio.c:122:62: error: argument 4 of type 'int[2]' with mismatched bound [-Werror=array-parameter=]
      122 | run_crypt(long offset, char *buffer, unsigned int count, int p[2])
          |                                                          ~~~~^~~~
    In file included from ../common/cryptio.c:45:
    /code/illumos-gate/proto/root_i386/usr/include/crypt.h:56:46: note: previously declared as 'int *'
       56 | extern int run_crypt(long, char *, unsigned, int *);
          |                                              ^~~~~
    ../common/cryptio.c:196:17: error: argument 1 of type 'int[2]' with mismatched bound [-Werror=array-parameter=]
      196 | crypt_close(int p[2])
          |             ~~~~^~~~
    In file included from ../common/cryptio.c:45:
    /code/illumos-gate/proto/root_i386/usr/include/crypt.h:51:24: note: previously declared as 'int *'
       51 | extern int crypt_close(int *);
          |                        ^~~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot, wsdiff is only showing debug info differences.

Actions #1

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1904
Actions #2

Updated by Toomas Soome 4 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 53496f229747a02889ac4f8518b2e4b44ff2f9e0

commit  53496f229747a02889ac4f8518b2e4b44ff2f9e0
Author: Toomas Soome <tsoome@me.com>
Date:   2022-01-17T21:22:34.000Z

    14349 libcrypt: mismatched bound
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF