Project

General

Profile

Actions

Bug #14350

closed

uath: mismatched bound

Added by Toomas Soome 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors with gcc 11:

    ../../common/io/uath/uath.c:1024:51: error: argument 2 of type 'uint8_t[6]' {aka 'unsigned char[6]'} with mismatched bound [-Werror=array-parameter=]
     1024 | uath_get_devstatus(struct uath_softc *sc, uint8_t macaddr[IEEE80211_ADDR_LEN])
          |                                           ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../common/io/uath/uath.c:249:57: note: previously declared as 'uint8_t *' {aka 'unsigned char *'}
      249 | static int      uath_get_devstatus(struct uath_softc *, uint8_t *);
          |                                                         ^~~~~~~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot, wsdiff is showing:

Old proto area: /code/14350/usr/src/uts/intel/uath/debug64/
New proto area: /tmp/debug64/
Results file: report.txt

/code/14350/usr/src/uts/intel/uath/debug64/uath.o
NOTE: ELF .text difference detected.

1452c1452
<     uath_cmd_lock_init+0x48:  ba 20 04 00 00     movl   $0x420,%edx
---
>     uath_cmd_lock_init+0x48:  ba 21 04 00 00     movl   $0x421,%edx
1481c1481
<     uath_cmd_lock_destroy+0x30: ba 2a 04 00 00     movl   $0x42a,%edx
---
>     uath_cmd_lock_destroy+0x30: ba 2b 04 00 00     movl   $0x42b,%edx
1556c1556
<     uath_cmd_lock_wait+0xe0:    ba 39 04 00 00     movl   $0x439,%edx
---
>     uath_cmd_lock_wait+0xe0:    ba 3a 04 00 00     movl   $0x43a,%edx
1588c1588
<     uath_cmd_lock_signal+0x50:  ba 54 04 00 00     movl   $0x454,%edx
---
>     uath_cmd_lock_signal+0x50:  ba 55 04 00 00     movl   $0x455,%edx
3764c3764
<     uath_reconnect+0x238:         ba 65 08 00 00     movl   $0x865,%edx
---
>     uath_reconnect+0x238:         ba 66 08 00 00     movl   $0x866,%edx
3938c3938
<     uath_disconnect+0xe0:         ba f5 08 00 00     movl   $0x8f5,%edx
---
>     uath_disconnect+0xe0:         ba f6 08 00 00     movl   $0x8f6,%edx
5742c5742
<     uath_attach+0x588:            ba ce 0b 00 00     movl   $0xbce,%edx
---
>     uath_attach+0x588:            ba cf 0b 00 00     movl   $0xbcf,%edx
5987c5987
<     uath_detach+0x198:            ba d8 0c 00 00     movl   $0xcd8,%edx
---
>     uath_detach+0x198:            ba d9 0c 00 00     movl   $0xcd9,%edx

Actions #1

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1905
Actions #2

Updated by Toomas Soome 4 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit d278f1c9d93ca9beb430b23636bc2a848535e0e0

commit  d278f1c9d93ca9beb430b23636bc2a848535e0e0
Author: Toomas Soome <tsoome@me.com>
Date:   2022-01-17T21:26:11.000Z

    14350 uath: mismatched bound
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF