Project

General

Profile

Actions

Bug #14352

closed

sha1: mismatched bound

Added by Toomas Soome 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error with gcc 11:

    ../../../common/crypto/sha1/sha1.c:638:44: error: argument 2 of type 'const uint8_t[64]' {aka 'const unsigned char[64]'} with mismatched bound [-Werror=array-parameter=]
      638 | SHA1Transform(SHA1_CTX *ctx, const uint8_t blk[64])
          |                              ~~~~~~~~~~~~~~^~~~~~~
    ../../../common/crypto/sha1/sha1.c:98:39: note: previously declared as 'const uint8_t *' {aka 'const unsigned char *'}
       98 | static void SHA1Transform(SHA1_CTX *, const uint8_t *);
          |                                       ^~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot. wsdiff is reporting nothing or debug info difference, depending on component built with sha1.c included.

Actions #1

Updated by Electric Monk 8 months ago

  • Gerrit CR set to 1907
Actions #2

Updated by Toomas Soome 7 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 5aaf65b1581c191cf1ecb7151a3ad599f33f45f9

commit  5aaf65b1581c191cf1ecb7151a3ad599f33f45f9
Author: Toomas Soome <tsoome@me.com>
Date:   2022-01-19T21:27:02.000Z

    14352 sha1: mismatched bound
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF