Project

General

Profile

Actions

Bug #14381

closed

libstmf: build error with gcc 11

Added by Toomas Soome 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors with gcc 11:

    ../common/stmf.c:3448:27: error: argument 1 of type 'uchar_t *' {aka 'unsigned char *'} declared as a pointer [-Werror=array-parameter=]
     3448 | stmfDevidFromWwn(uchar_t *wwn, stmfDevid *devid)
          |                  ~~~~~~~~~^~~
    In file included from ../common/stmf.c:41:
    /code/illumos-gate/proto/root_i386/usr/include/libstmf.h:323:30: note: previously declared as an array 'uchar_t[8]' {aka 'unsigned char[8]'}
      323 | int stmfDevidFromWwn(uchar_t wwn[8], stmfDevid *devid);
          |                      ~~~~~~~~^~~~~~
    cc1: all warnings being treated as errors

Match the declaration from header.

Testing done: wsdiff is showing only debug info difference.

Actions #1

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 1927
Actions #2

Updated by Toomas Soome 7 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 8c2e120d86add3ec9062486352618e0fc4a2161c

commit  8c2e120d86add3ec9062486352618e0fc4a2161c
Author: Toomas Soome <tsoome@me.com>
Date:   2022-01-11T17:53:06.000Z

    14381 libstmf: build error with gcc 11
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF