Project

General

Profile

Actions

Bug #14382

closed

gss_mechs: build errors with gcc 11

Added by Toomas Soome over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

Different errors in gss_mech:

    ../krb5/rcache/rc_file.c: In function 'krb5_rc_file_close_no_free':
    ../krb5/rcache/rc_file.c:166:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
      166 |  if (t->d.fd >= 0)
          |  ^~
    ../krb5/rcache/rc_file.c:20:20: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
       20 | #define FREE_RC(x) ((void) free((char *) (x)))
          |                    ^
    ../krb5/rcache/rc_file.c:168:5: note: in expansion of macro 'FREE_RC'
      168 |     FREE_RC(t);
          |     ^~~~~~~
    cc1: all warnings being treated as errors

    In file included from ../../dh_common/../dh_common/dh_common.h:34,
                     from ../../dh_common/dh_template.c:38,
                     from ../dh192.c:41:
    /code/illumos-gate/usr/src/lib/libnsl/include/rpcsvc/nis_dhext.h:159:20: error: argument 1 of type 'const char[]' with mismatched bound [-Werror=array-parameter=]
      159 | int getpublickey_g(const char [], keylen_t, algtype_t, char *, size_t);
          |                    ^~~~~~~~~~~~~
    In file included from ../dh192.c:39:
    ../fakensl.c:52:27: note: previously declared as 'const char[255]'
       52 | getpublickey_g(const char remotename[MAXNETNAMELEN], int keylen,
          |                ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
    In file included from ../../dh_common/../dh_common/dh_common.h:34,
                     from ../../dh_common/dh_template.c:38,
                     from ../dh192.c:41:
    /code/illumos-gate/usr/src/lib/libnsl/include/rpcsvc/nis_dhext.h:162:29: error: argument 1 of type 'const char[]' with mismatched bound [-Werror=array-parameter=]
      162 | int __getpublickey_cached_g(const char [], keylen_t, algtype_t, char *, size_t,
          |                             ^~~~~~~~~~~~~
    In file included from ../dh192.c:39:
    ../fakensl.c:43:36: note: previously declared as 'const char[255]'
       43 | __getpublickey_cached_g(const char remotename[MAXNETNAMELEN], int keylen,
          |                         ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot; wsdiff is only showing debug info difference.

Actions #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 1928
Actions #2

Updated by Toomas Soome over 1 year ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk over 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 3f2304d3d03b914a6bc6784aac74829493a6ec31

commit  3f2304d3d03b914a6bc6784aac74829493a6ec31
Author: Toomas Soome <tsoome@me.com>
Date:   2022-02-07T17:37:27.000Z

    14382 gss_mechs: build errors with gcc 11
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF