Project

General

Profile

Actions
Copy link

Bug #14383

closed

cfgadm_plugins: build errors with gcc 11

Added by Toomas Soome 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1929

Description

    ../common/cfga_fp.c:348:28: error: argument 1 of type 'const char *' declared as a pointer [-Werror=array-parameter=]
      348 | cfga_ap_id_cmp(const char *ap_id1, const char *ap_id2)
          |                ~~~~~~~~~~~~^~~~~~
    In file included from ../common/cfga_fp.h:83,
                     from ../common/cfga_fp.c:26:
    /code/illumos-gate/proto/root_i386/usr/include/config_admin.h:235:20: note: previously declared as an array 'const char[20]'
      235 | int cfga_ap_id_cmp(const cfga_ap_log_id_t,
          |                    ^~~~~~~~~~~~~~~~~~~~~~
    ../common/cfga_fp.c:348:48: error: argument 2 of type 'const char *' declared as a pointer [-Werror=array-parameter=]
      348 | cfga_ap_id_cmp(const char *ap_id1, const char *ap_id2)
          |                                    ~~~~~~~~~~~~^~~~~~
    In file included from ../common/cfga_fp.h:83,
                     from ../common/cfga_fp.c:26:
    /code/illumos-gate/proto/root_i386/usr/include/config_admin.h:236:5: note: previously declared as an array 'const char[20]'
      236 |     const cfga_ap_log_id_t);
          |     ^~~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

Testing done: wsdiff is reporting: 

/code/14383/usr/src/lib/cfgadm_plugins/fp/amd64/pics/cfga_fp.o
NOTE: ELF .debug_info difference detected.

Actions
Copy link
 #1

Updated by Electric Monk 7 months ago

  • Gerrit CR set to 1929
Actions
Copy link
 #2

Updated by Toomas Soome 7 months ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Electric Monk 7 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit f02e918df953cc4861bad053ba1e39dab00c3787

commit  f02e918df953cc4861bad053ba1e39dab00c3787
Author: Toomas Soome <tsoome@me.com>
Date:   2022-01-11T17:46:27.000Z

    14383 cfgadm_plugins: build errors with gcc 11
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF