Project

General

Profile

Actions

Bug #14398

closed

consolidate bhyve tests

Added by Patrick Mooney 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
bhyve
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

With the integration of #14367, there are two bhyve test directories shipped with system/bhyve/tests:
- /opt/bhyvetest: mevent tests for c-bhyve userspace
- /opt/bhyve-tests: memmap tests for kernel vmm component

It would be good to consolidate these so users could run all of the tests at once. (And for the filesystem to have less clutter)


Related issues

Related to illumos gate - Bug #14367: bhyve gpt mishandles small mappingsClosedPatrick Mooney

Actions
Actions #1

Updated by Patrick Mooney 6 months ago

  • Related to Bug #14367: bhyve gpt mishandles small mappings added
Actions #2

Updated by Marcel Telka 6 months ago

  • Subject changed from conslidate bhyve tests to consolidate bhyve tests
Actions #3

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 1945
Actions #4

Updated by Patrick Mooney 6 months ago

With the proposed change installed on a test machine, I can run all of the bhyve tests together with the provided runner:

root@carbide:~# /opt/bhyve-tests/bin/bhyvetest
Test: /opt/bhyve-tests/tests/memmap (run as root)                 [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/lists_delete (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_disable (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_pause (run as root)      [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_requeue (run as root)    [00:00] [PASS]

Results Summary
PASS       5

Running Time:   00:00:00
Percent passed: 100.0%
Log directory:  /var/tmp/test_results/20220114T051914

When run separately, their output agrees with the runner:

root@carbide:/opt/bhyve-tests/tests/mevent# ./lists_delete
PASS lists_delete
root@carbide:/opt/bhyve-tests/tests/mevent# ./read_disable
PASS read_disable
root@carbide:/opt/bhyve-tests/tests/mevent# ./read_pause
PASS read_pause
root@carbide:/opt/bhyve-tests/tests/mevent# ./read_requeue
PASS read_requeue
root@carbide:/opt/bhyve-tests/tests/mevent# cd ..
root@carbide:/opt/bhyve-tests/tests# ./memmap
root@carbide:/opt/bhyve-tests/tests# echo $?
0

Actions #5

Updated by Electric Monk 6 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit d327dbeacda682ba3d4efc9b451baa429ba8830c

commit  d327dbeacda682ba3d4efc9b451baa429ba8830c
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2022-01-14T16:19:16.000Z

    14398 consolidate bhyve tests
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF