Actions
Bug #14406
closedos-tests: definit test entry incorrect
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
Description
While running the os-tests, I saw the following:
$ pfexec /opt/os-tests/bin/ostest Warning: Test '/opt/os-tests/tests/definit' not added to this run because it failed verification.
If we look at that path, it is not actually a path to a binary, but rather a directory. This should have been opt/os-tests/tests/definit/definit
.
Related issues
Updated by Robert Mustacchi 4 months ago
I tested this by using the new runfline and running the tests:
rm@nienor:~$ pfexec /opt/os-tests/bin/ostest Test: /opt/os-tests/tests/clock_gettime.32 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/clock_gettime.64 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/definit/definit (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/eventfd.32 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/eventfd.64 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/imc_test (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/odirectory.32 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/odirectory.64 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/writev.32 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/writev.64 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/cores/core_prereqs (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/cores/coretests (run as root) [00:05] [PASS] Test: /opt/os-tests/tests/ddi_ufm/ufm-test-setup (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/ddi_ufm/ufm-test (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/ddi_ufm/ufm-test-cleanup (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/file-locking/runtests.32 (run as root) [00:21] [PASS] Test: /opt/os-tests/tests/file-locking/runtests.64 (run as root) [00:21] [PASS] Test: /opt/os-tests/tests/i386/ldt (run as root) [00:06] [PASS] Test: /opt/os-tests/tests/i386/badseg (run as root) [00:06] [PASS] Test: /opt/os-tests/tests/ksensor/ksensor_init (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/ksensor/ksensor_basic.32 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/ksensor/ksensor_basic.64 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/ksensor/ksensor_err.32 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/ksensor/ksensor_err.64 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/ksensor/ksensor_fini (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/libtopo/digraph-test (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/pf_key/acquire-compare (run as root) [00:43] [PASS] Test: /opt/os-tests/tests/pf_key/kmc-update (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/sdevfs/sdevfs_eisdir (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_aslr (run as root) [00:02] [PASS] Test: /opt/os-tests/tests/secflags/secflags_core (run as root) [00:01] [PASS] Test: /opt/os-tests/tests/secflags/secflags_dts (run as root) [00:11] [PASS] Test: /opt/os-tests/tests/secflags/secflags_elfdump (run as root) [00:01] [PASS] Test: /opt/os-tests/tests/secflags/secflags_forbidnullmap (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_limits (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_noexecstack (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_proc (run as root) [00:01] [PASS] Test: /opt/os-tests/tests/secflags/secflags_psecflags (run as root) [00:11] [PASS] Test: /opt/os-tests/tests/secflags/secflags_syscall (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_truss (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/secflags/secflags_zonecfg (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/sigqueue/sigqueue_queue_size (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/sockfs/conn (run as root) [00:05] [PASS] Test: /opt/os-tests/tests/sockfs/dgram (run as root) [00:05] [PASS] Test: /opt/os-tests/tests/sockfs/drop_priv (run as root) [00:07] [PASS] Test: /opt/os-tests/tests/sockfs/nosignal (run as root) [00:02] [PASS] Test: /opt/os-tests/tests/sockfs/rights.32 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/sockfs/rights.64 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/sockfs/sockpair (run as root) [00:10] [PASS] Test: /opt/os-tests/tests/sockfs/recvmsg.32 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/sockfs/recvmsg.64 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/stackalign/stackalign.32 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/stackalign/stackalign.64 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/stress/dladm-kstat (run as root) [00:20] [PASS] Test: /opt/os-tests/tests/syscall/open.32 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/syscall/open.64 (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/timer/timer_limit (run as root) [00:00] [PASS] Test: /opt/os-tests/tests/uccid/atrparse (run as root) [00:00] [PASS] Results Summary PASS 58 Running Time: 00:03:04 Percent passed: 100.0% Log directory: /var/tmp/test_results/20220115T200957
And if we dig into the actual test results, we'll see in the corresponding file:
$ cat /var/tmp/test_results/20220115T200957/definit/stdout Testing definit_test.32 Testing definit_test.64 All tests passed successfully
Updated by Robert Mustacchi 4 months ago
- Related to Bug #14208: zoneadmd should not inherit zoneadm's environment added
Updated by Electric Monk 4 months ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit cad3f045f59651045c4a2f7a7e0ca632c3d5c433
commit cad3f045f59651045c4a2f7a7e0ca632c3d5c433 Author: Robert Mustacchi <rm@fingolfin.org> Date: 2022-01-17T16:35:52.000Z 14406 os-tests: definit test entry incorrect Reviewed by: Patrick Mooney <pmooney@pfmooney.com> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Rich Lowe <richlowe@richlowe.net>
Actions