Project

General

Profile

Actions
Copy link

Feature #14408

closed

Remove usbgem GLDv2 bits

Added by Robert Mustacchi 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Robert Mustacchi
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1951

Description

While going through and considering using usbgem for something else, I realized we still had all the ifdefs present for GLDv2 support even though all usbgem based drivers all use GLDv3. This seemed like a prime opportunity to actually go through and remove this support, reducing one set of ifdefs in that code. Note, the GLDv2 support has never been used in the modules entire life in illumos and it is built with the GLDv3 definitions always.

As part of this, we'll also clean up the related GLDv3 ifdefs around different, old versions of the mac interfaces that we've never supported.

Actions
Copy link
 #1

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 1951
Actions
Copy link
 #2

Updated by Robert Mustacchi 4 months ago

  • Description updated (diff)

To test this I did a wsdiff. Te only bit that came up was a minor string table difference because gcc changed its sequence number used for certain anonymous functions in the usbgem driver. None of the leaf drivers changed. Here's the difference:

NOTE: ELF .strtab difference detected.

159,162c159,162
< 0002360   2   1   5  \0   _   _   f   u   n   c   _   _   .   2   3   2
<         00353132 75665f5f 5f5f636e 3233322e
< 0002400   3   6  \0   u   s   b   g   e   m   _   o   p   e   n   _   p
<         75003633 65676273 706f5f6d 705f6e65
---
> 0002360   2   3   7  \0   _   _   f   u   n   c   _   _   .   2   3   2
>         00373332 75665f5f 5f5f636e 3233322e
> 0002400   5   8  \0   u   s   b   g   e   m   _   o   p   e   n   _   p
>         75003835 65676273 706f5f6d 705f6e65
165,166c165,166
< 0002440   2   8   0  \0   u   s   b   g   e   m   _   c   l   o   s   e
<         00303832 67627375 635f6d65 65736f6c
---
> 0002440   3   0   2  \0   u   s   b   g   e   m   _   c   l   o   s   e
>         00323033 67627375 635f6d65 65736f6c
173,174c173,174
< 0002540   e  \0   _   _   f   u   n   c   _   _   .   2   3   3   2   6
<         5f5f0065 636e7566 322e5f5f 36323333
---
> 0002540   e  \0   _   _   f   u   n   c   _   _   .   2   3   3   4   8
>         5f5f0065 636e7566 322e5f5f 38343333
Actions
Copy link
 #3

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit ceb6b962688367d471aede9d55551e6b57bd9adc

commit  ceb6b962688367d471aede9d55551e6b57bd9adc
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2022-01-18T18:55:48.000Z

    14408 Remove usbgem GLDv2 bits
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions
Copy link

Also available in: Atom PDF