Project

General

Profile

Actions
Copy link

Bug #14430

closed

simplify bhyve vatpit

Added by Patrick Mooney 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Patrick Mooney
Category:
bhyve
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
1971

Description

The vATPIT emulation in bhyve carries a bunch of state in types that are too large and/or expansive for what they represent - using int for booleans, for example. It would be nice to clean this logic up, and make it more readable so that it is easier to deal with for kernel device import/export during a live migration.

Actions
Copy link
 #1

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 1971
Actions
Copy link
 #2

Updated by Patrick Mooney 4 months ago

I booted the normal array of guests for smoke-testing, while looking at the in-kernel data structures (via mdb -k) to observe PIT manipulations. Those guests booted and functioned normally. CentOS and OmniOS guests used the PIT early (for clock calibration), ignoring it for other time sources after that. Windows did not seem to touch it at all. OpenBSD continued to run the PIT after boot-up.

Actions
Copy link
 #3

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 8cbaa6a809af7f43b3da2420c9d29a3507893284

commit  8cbaa6a809af7f43b3da2420c9d29a3507893284
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2022-02-23T21:40:30.000Z

    14430 simplify bhyve vatpit
    Reviewed by: Dan Cross <cross@oxidecomputer.com>
    Approved by: Rich Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF