Project

General

Profile

Actions

Bug #14464

closed

want ugen nodes for devices attached by hid

Added by Dan McDonald 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

This commit: https://github.com/joyent/illumos-joyent/commit/ef863daaba22cc716ed3cfc450359044c2e6dde6

should really be upstreamed. While looking at a different USB issue in SmartOS, I saw this appeared to be the only difference between SmartOS and upstream.

Original Joyent ticket is here: https://smartos.org/bugview/OS-5887

Actions #1

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 1993
Actions #2

Updated by Dan McDonald 6 months ago

Testing: This has been in production in SmartOS for five years now.

Actions #3

Updated by Dan McDonald 6 months ago

Testing notes from OS-5887:

Testing done:

Using ivy in the lab
Plugged a yubikey, a usb mouse and a usb keyboard into it, checked that they operate as normal
Then checked that ugen nodes appear under /dev/usb and in /devices and that they have sensible minor numbers
Held some ugen nodes open with cat while typing to check nothing breaks
Built libusb and the Yubikey tools for illumos and installed
Verified that ykinfo, ykchalresp and ykpersonalize commands work correctly on the Yubikey (and the data they're getting is correct)
Also tested physically removing the USB HID device while ugen nodes were still open by a userland application. Behaves as expected (identically to usb_mid and ugen_skel in the same circumstances).
Actions #4

Updated by Electric Monk 6 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit cfe80fe3616624773746461f58f667b0c4141275

commit  cfe80fe3616624773746461f58f667b0c4141275
Author: Alex Wilson <alex.wilson@joyent.com>
Date:   2022-02-09T15:14:48.000Z

    14464 want ugen nodes for devices attached by hid
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Joshua M. Clulow <jmc@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF