Project

General

Profile

Actions
Copy link

Feature #14496

closed

git pbchk should look in .git/info for *.NOT files

Added by Gordon Ross 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Gordon Ross
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
2015

Description

The "git pbchk" command currently looks for the *.NOT files under TOP/.git/ but the conventional place for such things is TOP/.git/info/, which is where one finds the "exclude" file, for example.
Let's change the location where "git pbchk" looks.

Actions
Copy link
 #1

Updated by Gordon Ross 6 months ago

  • Category set to tools - gate/build tools
  • Status changed from New to In Progress
Actions
Copy link
 #2

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 2015
Actions
Copy link
 #3

Updated by Gordon Ross 5 months ago

Before the fix, I get a lot of noise from one file:
(which I really don't want to cstyle)

$ git nits -b il-wpts3
C style:
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 48: continuation line should be indented by 4 spaces
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 49: continuation line should be indented by 4 spaces
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 50: continuation line should be indented by 4 spaces
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 1691: stuff after multi-line case
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 1900: stuff after multi-line case
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 1902: stuff after multi-line case
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 1904: stuff after multi-line case
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 1906: stuff after multi-line case
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 2368: spaces instead of tabs
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 2414: spaces instead of tabs
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 2450: spaces instead of tabs
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 2734: spaces instead of tabs
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 2735: spaces instead of tabs
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 3485: stuff after multi-line case
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 3501: else and right brace should be on same line
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 3510: stuff after multi-line case
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 3529: else and right brace should be on same line
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 3539: stuff after multi-line case
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c: 3558: stuff after multi-line case
usr/src/uts/common/fs/smbsrv/smb_server.c: 1531: missing space after (void) cast
usr/src/uts/common/fs/smbsrv/smb2_create.c: 369: stuff after multi-line case

After the fix, I can create a cstyle.NOT file in:
$WS/.git/info/cstyle.NOT

containing one line:
usr/src/uts/common/fs/smbsrv/smb_cmn_oplock.c

Then running git nits shows:
$ git nits -b il-wpts3
C style:
usr/src/uts/common/fs/smbsrv/smb_server.c: 1531: missing space after (void) cast
usr/src/uts/common/fs/smbsrv/smb2_create.c: 369: stuff after multi-line case

Actions
Copy link
 #4

Updated by Electric Monk 5 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit c82c4676ac0cb87eb69c9444cf1a775e756ebbb9

commit  c82c4676ac0cb87eb69c9444cf1a775e756ebbb9
Author: Gordon Ross <gwr@racktopsystems.com>
Date:   2022-03-15T15:08:56.000Z

    14496 git pbchk should look in .git/info for *.NOT files
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF