Project

General

Profile

Actions
Copy link

Feature #14505

closed

libumem's umem_update thread could be named

Added by Andy Fiddaman 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Andy Fiddaman
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
2030

Description

At present, the umem_update thread that libumem creates does not have a name, which slightly spoils the output of tools that list threads, for example:

# prstat -L -p `pgrep -n bhyve`
   PID USERNAME  SIZE   RSS STATE  PRI NICE      TIME  CPU PROCESS/LWP
  2772 root     1095M   27M sleep   52    0   0:00:16 0.7% bhyve/2 [vcpu 0]
  2772 root     1095M   27M sleep   59    0   0:00:00 0.0% bhyve/6
  2772 root     1095M   27M sleep   59    0   0:00:00 0.0% bhyve/5 [vcpu 3]
  2772 root     1095M   27M sleep   59    0   0:00:00 0.0% bhyve/4 [vcpu 2]
  2772 root     1095M   27M sleep   59    0   0:00:00 0.0% bhyve/3 [vcpu 1]
  2772 root     1095M   27M sleep   59    0   0:00:00 0.0% bhyve/1 [mevent]

thread 6 here being the umem thread.

Actions
Copy link
 #1

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 2030
Actions
Copy link
 #2

Updated by Andy Fiddaman 5 months ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Andy Fiddaman 4 months ago

With this change:

% pfexec prstat -L -p `pgrep -n bhyve`
   PID USERNAME  SIZE   RSS STATE  PRI NICE      TIME  CPU PROCESS/LWP
   858 root      176M   24M sleep    1    0   0:00:06 0.6% bhyve/2 [vcpu 0]
   858 root      176M   24M sleep   59    0   0:00:00 0.0% bhyve/7 [rfb0 tx]
   858 root      176M   24M sleep   59    0   0:00:00 0.0% bhyve/6 [umem_update]
   858 root      176M   24M sleep   59    0   0:00:00 0.0% bhyve/5 [vcpu 3]
   858 root      176M   24M sleep   59    0   0:00:00 0.0% bhyve/4 [vcpu 2]
   858 root      176M   24M sleep   59    0   0:00:00 0.0% bhyve/3 [vcpu 1]
   858 root      176M   24M sleep   59    0   0:00:00 0.0% bhyve/1 [mevent]
Actions
Copy link
 #4

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 1aa1f41fe10c6220a7fbef328fac1b72a8355a01

commit  1aa1f41fe10c6220a7fbef328fac1b72a8355a01
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2022-04-23T11:02:39.000Z

    14495 bhyve VNC server should support alternate pixel formats
    14494 bhyve VNC server could support multiple connections
    14505 libumem's umem_update thread could be named
    14506 libidspace does not expose id_allocff()
    14640 bhyve VNC authentication fails with openssl3
    Reviewed by: Jason King <jason.brian.king+illumos@gmail.com>
    Reviewed by: Michael Zeller <mike@mikezeller.net>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF