Project

General

Profile

Actions

Bug #14512

closed

iwn: suspicious concatenation of string literals

Added by Toomas Soome 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors with clang:

    ../../common/io/iwn/if_iwnreg.h:1975:2: error: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Werror,-Wstring-concatenation]
            "DEBUG_0",
            ^
    ../../common/io/iwn/if_iwnreg.h:1974:2: note: place parentheses around the string literal to silence warning
            "NMI_INTERRUPT_BREAKPOINT" 
            ^
    1 error generated.

Testing done: build

Actions #1

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 2026
Actions #2

Updated by Toomas Soome 6 months ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk 6 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit b302a2007db5ab3847583f9a046d41c11789c092

commit  b302a2007db5ab3847583f9a046d41c11789c092
Author: Toomas Soome <tsoome@me.com>
Date:   2022-02-17T22:31:04.000Z

    14512 iwn: suspicious concatenation of string literals
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF