Project

General

Profile

Actions

Bug #14520

closed

sysevent/zfs_mod should use C99

Added by Andy Fiddaman 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

#14469 added the use of the __func__ definition to the sysevent ZFS module.
While this is supported by the default gnu89 standard in gate, it was technically only introduced with C99 so we should build this file with that standard.


Related issues

Related to illumos gate - Feature #14469: nvme could raise dynamic lun expansion syseventsClosedAndy Fiddaman

Actions
Actions #1

Updated by Andy Fiddaman 6 months ago

  • Related to Feature #14469: nvme could raise dynamic lun expansion sysevents added
Actions #2

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 2035
Actions #3

Updated by Andy Fiddaman 6 months ago

I've tested that the module still works as expected when built with C99, by generating DLE sysevents while running syseventd in debug mode, and confirming that the module re-opens the disk and does online expansion if the pool is configured for it.

wsdiff shows a lot of changes, almost entirely offsets that have changed.

Actions #4

Updated by Electric Monk 6 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit fed899dc728afbaa478e18a094b06ca0e9b96a8d

commit  fed899dc728afbaa478e18a094b06ca0e9b96a8d
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2022-02-26T17:37:04.000Z

    14520 sysevent/zfs_mod should use C99
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF