Project

General

Profile

Actions

Bug #14528

closed

nvme should return ENOTSUP for ioctls not supported by the hardware

Added by Hans Rosenfeld 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

Currently nvme doesn't even check whether firmware operations are supported by the hardware, relying on the failure of the firmware commands to return an appropriate error code. Instead of just sending unknown commands to the hardware, the driver should really check whether firmware operations are supported and return ENOTSUP if not.

The format ioctl has a similar problem, return EINVAL when it should return ENOTSUP instead.

Actions

Also available in: Atom PDF