nvmeadm should ignore requests to attach/detach ignored namespaces
When nvmeadm is run to attach or detach an ignored namespace, it will carry out the request and return an error message for the error returned by the nvme driver. This is all nice and well for interactive use, but it's a nuisance when doing recursive attach or detach of whole controllers, which is also an implicit part of the nvmeadm format and secure-erase commands. As most NVMe controllers support many (>32) namespaces of which usually only one is attachable, this will generate a load of pointless error messages.
Updated by Hans Rosenfeld 6 months ago
Testing: I've tested attaching and detaching of whole controllers and individual namespaces extensively, verifying that recursive
detach/attach of whole controllers that have ignored namespaces works without error messages, and also verifying that trying to attach a single ignored namespaces still causes the appropriate error. All of that was done in the context of Tintri's system, due to lack of suitable hardware I did not test on stock illumos-gate.
Updated by Electric Monk 6 months ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit 63cdc4a2836cf93078a5dd140d42583170a04953 Author: Hans Rosenfeld <firstname.lastname@example.org> Date: 2022-03-02T10:20:33.000Z 14529 nvmeadm should ignore requests to attach/detach ignored namespaces Reviewed by: Andrew Giles <email@example.com> Reviewed by: Guy Morrogh <firstname.lastname@example.org> Reviewed by: Robert Mustacchi <email@example.com> Reviewed by: Andy Fiddaman <firstname.lastname@example.org> Approved by: Dan McDonald <email@example.com>