Project

General

Profile

Actions
Copy link

Bug #14562

closed

apparently bad merge in l2arc_write_buffers

Added by Toomas Soome 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
2065

Description

Duplicate comment and asserts. Compared to OpenZFS code to verify. Found this issue while working on zstd compression update from OpenZFS, literally while inspecting the arc.c.

Testing done: build/install/boot.

Actions
Copy link
 #1

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 2065
Actions
Copy link
 #2

Updated by Toomas Soome 5 months ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Toomas Soome 5 months ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Igor Kozhukhov 5 months ago

Actions
Copy link
 #5

Updated by Toomas Soome 5 months ago

Igor Kozhukhov wrote in #note-4:

it is not a bad merge, you missed OpenZFS update:
https://github.com/openzfs/zfs/commit/a8f27ec6c5f89f721f0492ed7b07437ec439d83d

Igor Kozhukhov wrote in #note-4:

it is not a bad merge, you missed OpenZFS update:
https://github.com/openzfs/zfs/commit/a8f27ec6c5f89f721f0492ed7b07437ec439d83d

I see. thanks!

Actions
Copy link
 #6

Updated by Electric Monk 5 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit f43aa5faf71b05bec443dbb0af363ddeaff8ec17

commit  f43aa5faf71b05bec443dbb0af363ddeaff8ec17
Author: Toomas Soome <tsoome@me.com>
Date:   2022-03-22T22:17:38.000Z

    14562 apparently bad merge in l2arc_write_buffers
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link
 #7

Updated by Jason King 5 months ago

It looks like the OpenZFS change was after the original code as committed, so just hadn't been ported over yet.

Actions
Copy link

Also available in: Atom PDF