Bug #14562
closedapparently bad merge in l2arc_write_buffers
100%
Description
Duplicate comment and asserts. Compared to OpenZFS code to verify. Found this issue while working on zstd compression update from OpenZFS, literally while inspecting the arc.c.
Testing done: build/install/boot.
Updated by Igor Kozhukhov 5 months ago
it is not a bad merge, you missed OpenZFS update:
https://github.com/openzfs/zfs/commit/a8f27ec6c5f89f721f0492ed7b07437ec439d83d
Updated by Toomas Soome 5 months ago
Igor Kozhukhov wrote in #note-4:
it is not a bad merge, you missed OpenZFS update:
https://github.com/openzfs/zfs/commit/a8f27ec6c5f89f721f0492ed7b07437ec439d83d
Igor Kozhukhov wrote in #note-4:
it is not a bad merge, you missed OpenZFS update:
https://github.com/openzfs/zfs/commit/a8f27ec6c5f89f721f0492ed7b07437ec439d83d
I see. thanks!
Updated by Electric Monk 5 months ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
git commit f43aa5faf71b05bec443dbb0af363ddeaff8ec17
commit f43aa5faf71b05bec443dbb0af363ddeaff8ec17 Author: Toomas Soome <tsoome@me.com> Date: 2022-03-22T22:17:38.000Z 14562 apparently bad merge in l2arc_write_buffers Reviewed by: Andy Fiddaman <andy@omnios.org> Approved by: Dan McDonald <danmcd@joyent.com>
Updated by Jason King 5 months ago
It looks like the OpenZFS change was after the original code as committed, so just hadn't been ported over yet.