libXpm is not linked using its mapfile-vers
I noticed that libXpm is not linked properly because its mapfile-vers is not used during linking, even the Makefile attempts to use it: https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/x11/libXpm/Makefile#L40
This could cause compatibility issue with software built on old openindiana (I think oi-151). Such software will no longer run on hipster.
According to mapfile-vers, the following output should not be empty:
# nm /usr/lib/libXpm.so.4.11.0 | grep SUNW_1.1 #
Updated by Jean-Pierre André 7 months ago
Having been hit by this issue, I can suggest the patch below :
--- libXpm-3.5.13/src/Makefile.am.0 2019-12-13 05:51:40.000000000 +0000 +++ libXpm-3.5.13/src/Makefile.am 2022-03-23 18:42:01.519835952 +0000 @@ -5,7 +5,7 @@ AM_CPPFLAGS = -I$(top_srcdir)/include/X11/ AM_CFLAGS = $(CWARNFLAGS) $(XPM_CFLAGS) -libXpm_la_LDFLAGS = -version-number 4:11:0 -no-undefined +libXpm_la_LDFLAGS = -version-number 4:11:0 -no-undefined -Wl,-M../../../mapfile-vers libXpm_la_LIBADD = $(XPM_LIBS) libXpm_la_SOURCES = \
I am open to proposals for changing the non-satisfactory designation "../../../mapfile-vers", maybe I should put it in the main Makefile and reference $(LD_OPTIONS_SO), but having ../../.. there is even more confusing.