Project

General

Profile

Actions
Copy link

Bug #14587

closed

bhyve and viona belong in uts/intel

Added by Patrick Mooney 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
bhyve
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
2118

Description

The kernel component of bhyve and viona are not strictly specific to i86pc. They should be moved to uts/intel so that any applicable machine architecture can utilize them.

This also means moving HMA (the hypervisor multiplexing framework) and the SMT exclusion sources into uts/intel as well, since those are consumed by bhyve and other VMMs. Since those bits (and bhyve) require on MACHDEP-specific bits, they are built from the respective machine architecture (still i86pc in this case), driven by common makefiles in uts/intel.

Actions
Copy link
 #1

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 2118
Actions
Copy link
 #2

Updated by Patrick Mooney 4 months ago

With the proposed patch in place, all of the in-gate unit tests still pass:

Test: /opt/bhyve-tests/tests/mevent/vnode_zvol (run as root)      [00:02] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/rdmsr (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/inst_emul/wrmsr (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vatpit_freq (run as root)       [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vhpet_freq (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vlapic_freq (run as root)       [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vlapic_freq_periodic (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vlapic_mmio_access (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vlapic_msr_access (run as root) [00:00] [PASS]
Test: /opt/bhyve-tests/tests/kdev/vpmtmr_freq (run as root)       [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/lists_delete (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_disable (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_pause (run as root)      [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/read_requeue (run as root)    [00:00] [PASS]
Test: /opt/bhyve-tests/tests/mevent/vnode_file (run as root)      [00:09] [PASS]
Test: /opt/bhyve-tests/tests/vmm/fpu_getset (run as root)         [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/mem_devmem (run as root)         [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/mem_partial (run as root)        [00:00] [PASS]
Test: /opt/bhyve-tests/tests/vmm/mem_seg_map (run as root)        [00:00] [PASS]

Results Summary
PASS      19

Running Time:   00:00:13
Percent passed: 100.0%
Log directory:  /var/tmp/test_results/20220421T180201

Running a battery of guest smoke-tests reveals nothing out of the ordinary: they all booted and ran fine.

Actions
Copy link
 #3

Updated by Patrick Mooney 4 months ago

danmcd did a test build of this change on SmartOS. The resulting platform image ran both KVM and bhyve instances as normal.

Actions
Copy link
 #4

Updated by Patrick Mooney 4 months ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 7c8c0b8227679b4684566e408ccc96d6ef7175e9

commit  7c8c0b8227679b4684566e408ccc96d6ef7175e9
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2022-04-21T20:19:23.000Z

    14587 bhyve and viona belong in uts/intel
    Reviewed by: Keith Wesolowski <wesolows@oxide.computer>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF