Project

General

Profile

Actions

Bug #14602

closed

ttymon: cleanup

Added by Toomas Soome 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Remove warning suppressions, enable smatch.
Fix prototypes and ansify.
clean up extern and globals.
cstyle cleanup.

No functional changes intended.

Testing done: build/install/boot, ttymon does function as expected. Used standard console setup (with VT enabled), with local console (text) and serial console.


Related issues

Related to illumos gate - Bug #14609: loader: os console in options menu should use first name from listClosedToomas Soome

Actions
Related to illumos gate - Bug #14673: ttymon checkut_line() could be improvedNew

Actions
Related to illumos gate - Bug #14674: ttymon check_label() should have better diagnosticsNew

Actions
Actions #1

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 2086
Actions #2

Updated by Toomas Soome 4 months ago

  • Related to Bug #14609: loader: os console in options menu should use first name from list added
Actions #3

Updated by Toomas Soome 3 months ago

  • Related to Bug #14673: ttymon checkut_line() could be improved added
Actions #4

Updated by Toomas Soome 3 months ago

  • Related to Bug #14674: ttymon check_label() should have better diagnostics added
Actions #5

Updated by Toomas Soome 3 months ago

  • Description updated (diff)
Actions #6

Updated by Toomas Soome 3 months ago

  • Description updated (diff)
Actions #7

Updated by Electric Monk 3 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 3bb2c1567625e7b11f8c2a5335125224717af64a

commit  3bb2c1567625e7b11f8c2a5335125224717af64a
Author: Toomas Soome <tsoome@me.com>
Date:   2022-05-16T21:38:35.000Z

    14602 ttymon: cleanup
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF