Project

General

Profile

Actions

Bug #14604

closed

bios enumerated serial should use 1275 compatible names

Added by Rich Lowe 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

at present, serial enumerated by the BIOS as part of a workaround uses incorrectly formatted compatible properties.

I happen to have a NUC6i7KYB which demonstrates this.

                    name='model' type=string items=1
                        value='Standard PC COM port'
                    name='compatible' type=string items=1
                        value='PNP0500'

that isn't a valid 1275-style compatible name for a plug-n-play device, which are formed pnpVVV,PPPP it should be pnpPNP,500

Actions #1

Updated by Electric Monk 5 months ago

  • Gerrit CR set to 2088
Actions #2

Updated by Rich Lowe 5 months ago

testing:

Booting on the affected system, and checking the compatible property on the serial was correctly formed
Actions #3

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 07a53f3dc8bc5e4d64bde9b92063de65f06dcf19

commit  07a53f3dc8bc5e4d64bde9b92063de65f06dcf19
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2022-04-02T19:24:24.000Z

    14604 bios enumerated serial should use 1275 compatible names
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF