Project

General

Profile

Actions

Bug #14609

closed

loader: os console in options menu should use first name from list

Added by Toomas Soome 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:

Description

The current os_console setup in options menu is assuming single value set in console variable. Since all usable device names for kernel have 4 chars, we can only compare first 4 chars, and ignore the rest. This does also follow the kernel logic to use first name from console variable (in case the os_console is not set).

Note the console variable setter function does validate the console names, so we always do have correct name(s) in console variable.

Testing done: verify the correct os_console value is set in options menu and on boot. With console="ttya,text", we should have os_console set to ttya. Note, full fix is provided with 14585.


Related issues

Related to illumos gate - Feature #14580: loader.efi: detect console from ConOut/ConOutDevClosedToomas Soome

Actions
Related to illumos gate - Bug #14584: unix: console property should only have one valueClosedToomas Soome

Actions
Related to illumos gate - Feature #12389: loader should consult with ACPI SPCR table for serial consoleClosedToomas Soome

Actions
Related to illumos gate - Bug #14585: loader: should preserve order of console device listClosedToomas Soome

Actions
Related to illumos gate - Bug #14596: cstyle should allow empty increment with for loopIn ProgressToomas Soome

Actions
Related to illumos gate - Bug #14602: ttymon: cleanupClosedToomas Soome

Actions
Related to illumos gate - Feature #14607: Add CONS_GETDEV so we can see which port is /dev/consoleClosedToomas Soome

Actions
Related to illumos gate - Feature #14608: ttymon should use tty-mode propertyClosedToomas Soome

Actions
Actions #1

Updated by Electric Monk 6 months ago

  • Gerrit CR set to 2092
Actions #2

Updated by Toomas Soome 6 months ago

  • Related to Feature #14580: loader.efi: detect console from ConOut/ConOutDev added
Actions #3

Updated by Toomas Soome 6 months ago

  • Related to Bug #14584: unix: console property should only have one value added
Actions #4

Updated by Toomas Soome 6 months ago

  • Related to Feature #12389: loader should consult with ACPI SPCR table for serial console added
Actions #5

Updated by Toomas Soome 6 months ago

  • Related to Bug #14585: loader: should preserve order of console device list added
Actions #6

Updated by Toomas Soome 6 months ago

  • Related to Bug #14596: cstyle should allow empty increment with for loop added
Actions #7

Updated by Toomas Soome 6 months ago

Actions #8

Updated by Toomas Soome 6 months ago

  • Related to Feature #14607: Add CONS_GETDEV so we can see which port is /dev/console added
Actions #9

Updated by Toomas Soome 6 months ago

  • Related to Bug #2091: sd fails to power up some disks added
Actions #10

Updated by Toomas Soome 6 months ago

  • Related to Bug #2092: terrible performance from PCFS added
Actions #11

Updated by Toomas Soome 6 months ago

  • Related to deleted (Bug #2091: sd fails to power up some disks)
Actions #12

Updated by Toomas Soome 6 months ago

  • Related to deleted (Bug #2092: terrible performance from PCFS)
Actions #13

Updated by Toomas Soome 6 months ago

  • Related to Feature #14608: ttymon should use tty-mode property added
Actions #14

Updated by Toomas Soome 5 months ago

  • Description updated (diff)
Actions #15

Updated by Toomas Soome 5 months ago

  • Description updated (diff)
Actions #16

Updated by Electric Monk 5 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 08ae0f1eeaa2952f05e6cc3e67da55db918f8e4a

commit  08ae0f1eeaa2952f05e6cc3e67da55db918f8e4a
Author: Toomas Soome <tsoome@me.com>
Date:   2022-05-16T21:30:37.000Z

    14609 loader: os console in options menu should use first name from list
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF