Project

General

Profile

Actions

Bug #14617

closed

svc:/network/ipmp maintenance in shared IP zone

Added by Andy Fiddaman 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
networking
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

In a shared IP zone, the network/ipmp services goes into maintenance, and it should not.

[ Apr  4 13:10:47 Enabled. ]
[ Apr  4 13:10:49 Executing start method ("/lib/svc/method/net-ipmp"). ]
[ Apr  4 13:10:49 Method "start" exited with status 95. ]

The problem here is that the method script for the network/ipmp service contains this line:

smf_configure_ip || exit $SMF_EXIT_ERR_FATAL

and, in /lib/svc/share/smf_include.sh

# smf_configure_ip
#
#  Returns zero (success) if this zone needs IP to be configured i.e.
#  the global zone or has an exclusive stack.  1 otherwise.
#

The logic here is wrong, if the zone IP does not need to be configured, then the IPMP daemon (in.mpathd) does not need to run in this zone. The service should not exit with a fatal error, leaving it in a maintenance state. The SMF_EXIT_NODAEMON status was made for this type of case - smf_method(7) describes it as:

Method exited successfully but purposefully leaves no processes remaining in
the contract; it should be treated as if it had a transient service model.


Related issues

Related to illumos gate - Feature #2554: ipadm needs IPMP configuration supportClosed2012-03-28

Actions
Actions #1

Updated by Andy Fiddaman 4 months ago

  • Related to Feature #2554: ipadm needs IPMP configuration support added
Actions #2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 2096
Actions #3

Updated by Andy Fiddaman 4 months ago

  • Description updated (diff)
Actions #4

Updated by Andy Fiddaman 4 months ago

After applying the associated patch, the service comes online in a shared-ip zone, without any processes in the contract (as expected).

root@titan:~# svcs -p network/ipmp
STATE          STIME    FMRI
online          9:31:57 svc:/network/ipmp:default
Actions #5

Updated by Andy Fiddaman 4 months ago

  • Description updated (diff)
Actions #6

Updated by Electric Monk 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 57cf819efa50a6a3b3a478c25a098c29722eb358

commit  57cf819efa50a6a3b3a478c25a098c29722eb358
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2022-04-05T19:32:01.000Z

    14617 svc:/network/ipmp maintenance in shared IP zone
    Reviewed by: Marco van Wieringen <mvw@planets.elm.net>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF