Project

General

Profile

Actions

Bug #14626

closed

zlib: update to zlib-1.2.12

Added by Toomas Soome 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-25032

Our copy of zlib is maintained in https://github.com/illumos/zlib, this update is based on illumos/zlib-1.2.12 branch.

Testing done: build/install/boot. Before boot I did create dataset with compression=gzip, put some files on it and confirmed access from both loader and zfs. Also loader is able to process gzipped boot_archive (uncompressed in memory by loader before we jump to kernel).

zfs-tests. Since there are many failing tests, I did pick up only compression in file names:

[/opt/zfs-tests/tests/functional/acl/trivial]
tests = ['zfs_acl_compress_001_pos']

[/opt/zfs-tests/tests/functional/cli_root/zdb]
tests = ['zdb_001_neg', 'zdb_002_pos', 'zdb_003_pos', 'zdb_004_pos',
    'zdb_005_pos', 'zdb_decompress_zstd']
pre =
post =

[/opt/zfs-tests/tests/functional/cli_root/zfs_set]
tests = ['compression_001_pos']

[/opt/zfs-tests/tests/functional/compression]
tests = ['compress_001_pos', 'compress_002_pos', 'compress_003_pos',
    'compress_004_pos', 'compress_zstd_bswap', 'l2arc_compressed_arc',
    'l2arc_compressed_arc_disabled', 'l2arc_encrypted',
    'l2arc_encrypted_no_compressed_arc']

[/opt/zfs-tests/tests/functional/nopwrite]
tests = ['nopwrite_varying_compression']

[/opt/zfs-tests/tests/functional/rsend]
tests = ['send-c_mixed_compression']

The result is:

Results Summary
PASS      25

Running Time:   00:05:33
Percent passed: 100.0%
Log directory:  /var/tmp/test_results/20220408T163401
tsoome@test:~$


Related issues

Related to illumos gate - Feature #10695: import zlib-1.2.11ClosedToomas Soome2019-04-06

Actions
Related to illumos gate - Bug #124: uts/common/zmod/THIRDPARTYLICENSE is out-of-dateClosedMarcel Telka2010-08-30

Actions
Actions #1

Updated by Electric Monk 3 months ago

  • Gerrit CR set to 2106
Actions #2

Updated by Marcel Telka 3 months ago

Actions #3

Updated by Marcel Telka 3 months ago

  • Related to Bug #124: uts/common/zmod/THIRDPARTYLICENSE is out-of-date added
Actions #4

Updated by Toomas Soome 3 months ago

  • Description updated (diff)
Actions #5

Updated by Toomas Soome 3 months ago

  • Description updated (diff)
Actions #6

Updated by Electric Monk 2 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 148fd93e57d3d5813d90f1291e6bd30de45c7723

commit  148fd93e57d3d5813d90f1291e6bd30de45c7723
Author: Toomas Soome <tsoome@me.com>
Date:   2022-05-03T20:21:45.000Z

    14626 zlib: update to zlib-1.2.12
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Klaus Ziegler <klausz@haus-gisela.de>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF