Project

General

Profile

Actions

Bug #14637

closed

various Makefiles should have more faith in Makefile.master

Added by Rich Lowe 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Several Makefiles, but most noticeably Makefile.cmd re-define things from Makefile.master, and make them worse.
They should stop.

Actions #1

Updated by Rich Lowe 4 months ago

testing:

wsdiff, no difference at all in resulting binaries

Actions #2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 2113
Actions #3

Updated by Electric Monk 4 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 02b17e23cf5bf66a5ea787e066ae3d1aa49bd856

commit  02b17e23cf5bf66a5ea787e066ae3d1aa49bd856
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2022-04-26T20:30:42.000Z

    14637 various Makefiles should have more faith in Makefile.master
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF