remove blanket smatch gag from bhyve kernel
The bhyve (kernel vmm) Makefile has gagged some smatch checks across the entire module:
# 3rd party code SMOFF += all_func_returns
It would be nice to clean up the code base so that if any exceptions persist (at least in the short term), they can be covered by more constrained exceptions.
Updated by Patrick Mooney 2 months ago
Even though this change should result in effectively no change in behavior, its scope is a bit too large to make testing via
With this patch applied, the normal battery of guest OSes boot and run fine on both AMD and Intel hardware.
Updated by Electric Monk 2 months ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
commit e0994bd28f025d3d74315f7479562b6be19773c3 Author: Patrick Mooney <email@example.com> Date: 2022-04-29T21:43:44.000Z 14649 remove blanket smatch gag from bhyve kernel Reviewed by: Toomas Soome <firstname.lastname@example.org> Reviewed by: Andy Fiddaman <email@example.com> Reviewed by: Dan Cross <firstname.lastname@example.org> Approved by: Robert Mustacchi <email@example.com>