Bug #14649
closed
remove blanket smatch gag from bhyve kernel
100%
Description
The bhyve (kernel vmm) Makefile has gagged some smatch checks across the entire module:
# 3rd party code SMOFF += all_func_returns
It would be nice to clean up the code base so that if any exceptions persist (at least in the short term), they can be covered by more constrained exceptions.
Updated by Patrick Mooney 4 months ago
Even though this change should result in effectively no change in behavior, its scope is a bit too large to make testing via wsdiff feasible.
With this patch applied, the normal battery of guest OSes boot and run fine on both AMD and Intel hardware.
Updated by Patrick Mooney 4 months ago
The bhyve test suite continues to run successfully on both AMD and Intel as well.
Updated by Patrick Mooney 4 months ago
Andyf did further testing with this on OmniOS to confirm that bhyve-in-a-zone remained working:
I've run every test I could think of with 14649, no problems to report
Updated by Electric Monk 4 months ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
git commit e0994bd28f025d3d74315f7479562b6be19773c3
commit e0994bd28f025d3d74315f7479562b6be19773c3
Author: Patrick Mooney <pmooney@pfmooney.com>
Date: 2022-04-29T21:43:44.000Z
14649 remove blanket smatch gag from bhyve kernel
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Andy Fiddaman <andy@omnios.org>
Reviewed by: Dan Cross <cross@oxidecomputer.com>
Approved by: Robert Mustacchi <rm@fingolfin.org>