Bug #1465

oi-build openssl has too much quoting around LINT_FLAGS

Added by Alasdair Lumsden over 2 years ago. Updated over 2 years ago.

Status:Resolved Start date:2011-09-04
Priority:Normal Due date:
Assignee:Alasdair Lumsden % Done:

100%

Category:oi-build
Target version:-
Difficulty:Bite-size Tags:needs-triage

Description

The openssl oi-build Makefile adds quoting to LINT_FLAGS which causes the publish step to fail horribly, since all the arguments get treated as one.

This is a trivial fix:

diff --git a/components/openssl/openssl-1.0.0/Makefile b/components/openssl/openssl-1.0.0/Makefile
--- a/components/openssl/openssl-1.0.0/Makefile
+++ b/components/openssl/openssl-1.0.0/Makefile
@ -165,10 +165,10 @
LFLAGS_64 := -I$(BUILD_DIR_64)/include $(LINT_FLAGS)

  1. Set modified lint flags for our lint library targets.
    -$(BUILD_DIR_32)/llib-lcrypto.ln: LINT_FLAGS="$(LFLAGS_32)"
    -$(BUILD_DIR_32)/llib-lssl.ln: LINT_FLAGS="$(LFLAGS_32)"
    -$(BUILD_DIR_64)/llib-lcrypto.ln: LINT_FLAGS="$(LFLAGS_64)"
    -$(BUILD_DIR_64)/llib-lssl.ln: LINT_FLAGS="$(LFLAGS_64)"
    +$(BUILD_DIR_32)/llib-lcrypto.ln: LINT_FLAGS=$(LFLAGS_32)
    +$(BUILD_DIR_32)/llib-lssl.ln: LINT_FLAGS=$(LFLAGS_32)
    +$(BUILD_DIR_64)/llib-lcrypto.ln: LINT_FLAGS=$(LFLAGS_64)
    +$(BUILD_DIR_64)/llib-lssl.ln: LINT_FLAGS=$(LFLAGS_64)
test:          $(NO_TESTS)

History

Updated by Alasdair Lumsden over 2 years ago

  • Status changed from New to Resolved
  • % Done changed from 50 to 100

Also available in: Atom PDF