Bug #14650
closed
remove smatch gag from viona
Added by Patrick Mooney 4 months ago.
Updated 3 months ago.
Description
The kernel portion of viona has been building with SMOFF += all_func_returns.
It would be nice to fix up all of the errors hidden by that, and enable the full smatch suite for the module.
Since this change should result in effectively no change, I tested with wsdiff. Besides the typical noise resulting from parts of the build depending on git ref or date, the only change was related to an assertion being moved to a different line:
usr/kernel/drv/amd64/viona
NOTE: ELF .text difference detected.
5793c5793
< viona_tx+0x168: ba e0 02 00 00 movl $0x2e0,%edx
---
> viona_tx+0x168: ba e4 02 00 00 movl $0x2e4,%edx
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
git commit ce9221f7c49d15d77c5f2958868f3319f95c7a06
commit ce9221f7c49d15d77c5f2958868f3319f95c7a06
Author: Patrick Mooney <pmooney@pfmooney.com>
Date: 2022-04-26T05:13:15.000Z
14650 remove smatch gag from viona
Reviewed by: Andy Fiddaman <andy@omnios.org>
Reviewed by: Toomas Soome <tsoome@me.com>
Approved by: Robert Mustacchi <rm@fingolfin.org>
Also available in: Atom
PDF
Updated by 
Updated by