Project

General

Profile

Actions
Copy link

Bug #14665

closed

perl modules have no SONAME, swallow linker flags

Added by Rich Lowe 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
2133

Description

The perl modules use Makefile.lib but don't set DYNLIB, this leaves SONAME empty, so they end up doing just -Wl,-h this means we swallow the next flag as the SONAME in this case -ztext

Actions
Copy link
 #1

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 2133
Actions
Copy link
 #2

Updated by Rich Lowe 4 months ago

tested with wsdiff, checking that the new modules have a SONAME, also in combination with #14666 running the test suites where they exist (with a similar caveat that I don't have a sufficiently NUMA platform for all the Lgrp tests)

Actions
Copy link
 #3

Updated by Electric Monk 3 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit d5080bc30a219a555eac2067f14ea003864b617f

commit  d5080bc30a219a555eac2067f14ea003864b617f
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2022-05-09T21:16:22.000Z

    14665 perl modules have no SONAME, swallow linker flags
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF