Project

General

Profile

Actions
Copy link

Bug #14667

closed

libfru doesn't really need its own BUILD.SO

Added by Rich Lowe 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Rich Lowe
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
2135

Description

libfru's makefiles have their own BUILDCCC.SO specifically to somewhat misuse $(LINK.cc) to acquire CCNEEDED. This seems to be because BUILDCCC.SO lacked CCNEEDED, which is being changed in #14666, so we can just use the regular BUILDCCC.SO here

Related issues

Blocked by illumos gate - Bug #14666: BUILD.SO rules shouldn't change search paths, should be consistentClosedRich Lowe

Actions
Actions
Copy link
 #1

Updated by Rich Lowe 4 months ago

  • Blocked by Bug #14666: BUILD.SO rules shouldn't change search paths, should be consistent added
Actions
Copy link
 #2

Updated by Electric Monk 4 months ago

  • Gerrit CR set to 2135
Actions
Copy link
 #3

Updated by Rich Lowe 4 months ago

tested with building and wsdiff and thought about why differences occur (changes to the order of the link command line)

Actions
Copy link
 #4

Updated by Electric Monk 3 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 2c65701281156d8db8fa6f6f9c5faa6ca021c621

commit  2c65701281156d8db8fa6f6f9c5faa6ca021c621
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2022-05-09T21:16:22.000Z

    14667 libfru doesn't really need its own BUILD.SO
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF