Project

General

Profile

Actions

Bug #14670

closed

nvmeadm refactor for option parsing

Added by Hans Rosenfeld 25 days ago. Updated 5 days ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The nvmeadm utility got a mechanism for option parsing for subcommands a while back. It would be good if all subcommands that accept command line switches would use this feature. Right now there is only secure-erase, but certainly more will be added in the future.

To support this, the option parsing mechanism in nvmeadm needs to be extended.

Actions #1

Updated by Electric Monk 19 days ago

  • Gerrit CR set to 2140
Actions #2

Updated by Hans Rosenfeld 5 days ago

Testing: I've been running these changes for a few months now, implementing new nvmeadm commands that use this feature.

Actions #3

Updated by Electric Monk 5 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit a3bac573c955fec12942b4bfa5d10b68931210cb

commit  a3bac573c955fec12942b4bfa5d10b68931210cb
Author: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
Date:   2022-05-23T20:52:31.000Z

    14670 nvmeadm refactor for option parsing
    Reviewed by: Andrew Giles <agiles@tintri.com>
    Reviewed by: Ben Jameson <bjameson@tintri.com>
    Reviewed by: Guy Morrogh <gmorrogh@tintri.com>
    Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF