Project

General

Profile

Actions

Feature #14687

closed

need in-kernel strtok_r()

Added by Hans Rosenfeld 16 days ago. Updated 5 days ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

14686 needs an in-kernel implementation of strtok_r(). Some drivers already have their own private implementation, and that nees to be cleaned up.

Actions #1

Updated by Electric Monk 16 days ago

  • Gerrit CR set to 2148
Actions #2

Updated by Hans Rosenfeld 8 days ago

Testing: If I'm mistaken the code is identical to what is in libc (minus the {} I added during review), and it has been in Tintri's product for a few years. I did not explicitly test the changes in sd and scsa2usb, though.

Actions #3

Updated by Electric Monk 5 days ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 29219719c034367724cbf77434175b3c4e681e43

commit  29219719c034367724cbf77434175b3c4e681e43
Author: Enyew Tan <enyew@tegile.com>
Date:   2022-05-23T08:02:28.000Z

    14687 need in-kernel strtok_r()
    Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org>
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF