Bug #1471
openmdb ::cycinfo column output not lined up with headers
0%
Description
Running current illumos bits, the ::cycinfo -v columnar output (below the tree) doesn't line up under the column headers in my presumed-to-be-normal terminal.
It makes it particularly annoying to read quickly.
Updated by Rich Lowe over 11 years ago
* Yes, this is very weak. Full 16-column-wide 64-bit addresses screw up * ::cycinfo's very carefully planned 80-column layout. We set the column * width for addresses to be 11 (instead of 16), knowing that the kernel * heap (from which these data structures are allocated) starts at * 0x0000030000000000, and isn't likely to extend to 0x0000100000000000.
Nice logic, SPARCy (see what I did there?)
On SPARC this is true, on i386 it doesn't matter. On AMD64, however, it is false. 64bit kernel addresses are always 16 hex digits.
Updated by Rich Lowe over 11 years ago
While here, I'll also fix the output of the "PEND" header in the ::cycinfo -V output, which is missing since it has a format of "%*s", and is being taken as a width. (no warnings about this? not lint? none of the compilers?)
Updated by Rich Lowe over 11 years ago
Sigh, actually, it's missing a format entirely. I mis-counted. Still surprised there's no warning, however.
Updated by Josef Sipek over 9 years ago
Pretty sure the lack of a warning is due to mdb_printf not being labeled as printf-like.