Project

General

Profile

Actions

Bug #1471

open

mdb ::cycinfo column output not lined up with headers

Added by Rich Lowe almost 10 years ago. Updated almost 8 years ago.

Status:
In Progress
Priority:
Low
Assignee:
Category:
-
Start date:
2011-09-05
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

Running current illumos bits, the ::cycinfo -v columnar output (below the tree) doesn't line up under the column headers in my presumed-to-be-normal terminal.

It makes it particularly annoying to read quickly.

Actions #1

Updated by Rich Lowe almost 10 years ago

 * Yes, this is very weak.  Full 16-column-wide 64-bit addresses screw up
 * ::cycinfo's very carefully planned 80-column layout.  We set the column
 * width for addresses to be 11 (instead of 16), knowing that the kernel
 * heap (from which these data structures are allocated) starts at
 * 0x0000030000000000, and isn't likely to extend to 0x0000100000000000.

Nice logic, SPARCy (see what I did there?)

On SPARC this is true, on i386 it doesn't matter. On AMD64, however, it is false. 64bit kernel addresses are always 16 hex digits.

Actions #2

Updated by Rich Lowe almost 10 years ago

  • Assignee set to Rich Lowe
Actions #3

Updated by Rich Lowe almost 10 years ago

While here, I'll also fix the output of the "PEND" header in the ::cycinfo -V output, which is missing since it has a format of "%*s", and is being taken as a width. (no warnings about this? not lint? none of the compilers?)

Actions #4

Updated by Rich Lowe almost 10 years ago

Sigh, actually, it's missing a format entirely. I mis-counted. Still surprised there's no warning, however.

Actions #5

Updated by Rich Lowe almost 10 years ago

  • Status changed from New to In Progress
Actions #6

Updated by Josef Sipek almost 8 years ago

Pretty sure the lack of a warning is due to mdb_printf not being labeled as printf-like.

Actions

Also available in: Atom PDF