Project

General

Profile

Actions

Bug #14711

closed

wsdiff should display SHT_REL symbolically

Added by Rich Lowe about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

For reasons I don't know, wsdiff only does 'elfdump -r' to display relocations usefully for SHT_RELA, not SHT_REL. On x86, this means it does not show relocations in a useful fashion for 32bit binaries

Actions #1

Updated by Electric Monk about 1 month ago

  • Gerrit CR set to 2162
Actions #2

Updated by Rich Lowe about 1 month ago

testing:
wsdiff of an illumos change that shows this off
before:

@@ -1,7 +1,7 @@
-0000000 034     006  \b 006 005  \0  \0 024     006  \b 006   (  \0  \0
-        0806201c 00000506 08062014 00002806
-0000020 200   " 006  \b 005      \0  \0   @   & 006  \b 005 007  \0  \0
-        08062280 00002005 08062640 00000705
-0000040   <     006  \b 006 037  \0  \0   8     006  \b 006 036  \0  \0
-        0806203c 00001f06 08062038 00001e06
+0000000   @   & 006  \b 005 007  \0  \0   <     006  \b 006 037  \0  \0
+        08062640 00000705 0806203c 00001f06
+0000020   8     006  \b 006 036  \0  \0 034     006  \b 006 005  \0  \0
+        08062038 00001e06 0806201c 00000506
+0000040 024     006  \b 006   (  \0  \0 200   " 006  \b 005      \0  \0
+        08062014 00002806 08062280 00002005
 0000060

after:

 Relocation Section:  .SUNW_reloc
     type                       offset             section        symbol
-  R_386_GLOB_DAT            0x806201c             .SUNW_reloc    __start_crt_compiler
-  R_386_GLOB_DAT            0x8062014             .SUNW_reloc    __fsr_init_value
-  R_386_COPY                0x8062280             .SUNW_reloc    __iob
   R_386_COPY                0x8062640             .SUNW_reloc    __stack_chk_guard
   R_386_GLOB_DAT            0x806203c             .SUNW_reloc    _ITM_registerTMCloneTable
   R_386_GLOB_DAT            0x8062038             .SUNW_reloc    _ITM_deregisterTMCloneTable
+  R_386_GLOB_DAT            0x806201c             .SUNW_reloc    __start_crt_compiler
+  R_386_GLOB_DAT            0x8062014             .SUNW_reloc    __fsr_init_value
+  R_386_COPY                0x8062280             .SUNW_reloc    __iob

Actions #3

Updated by Electric Monk about 1 month ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit b0d58672df8644288a5fdce6ae229eaaa0db2de7

commit  b0d58672df8644288a5fdce6ae229eaaa0db2de7
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2022-05-27T20:16:36.000Z

    14711 wsdiff should display SHT_REL symbolically
    Reviewed by: Jason King <jason.brian.king@gmail.com>
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF