Project

General

Profile

Actions

Bug #14715

closed

libsa: Fix a bug in nvlist creation

Added by Toomas Soome about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Patch picked from FreeBSD:

https://reviews.freebsd.org/D35254

When adding an entry to an nvlist, the data buffer might need to be resized. When this happens, the XDR encoder's notion of the buffer size also needs to be updated, otherwise the operation may erroneously fail.

Testing done: build/install/boot.

Actions #1

Updated by Electric Monk about 1 month ago

  • Gerrit CR set to 2165
Actions #2

Updated by Yuri Pankov about 1 month ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk about 1 month ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 43075873f664db76209f1fdf87cb3961a113bfaf

commit  43075873f664db76209f1fdf87cb3961a113bfaf
Author: Mark Johnston <markj@FreeBSD.org>
Date:   2022-05-27T19:51:15.000Z

    14715 libsa: Fix a bug in nvlist creation
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Reviewed by: Gordon Ross <Gordon.W.Ross@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Dan McDonald <danmcd@mnx.io>

Actions

Also available in: Atom PDF